Equeue chain, add documentation of using equeue_destroy #11491
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Changed the order of destroying queues because it is needed to destroy queues in specified order when they are chained.
ciarmcom
requested review from
geky,
jamesbeyond,
kimlep01,
kjbracey,
maciejbocianski and
a team
|
@Tharazi97, thank you for your changes. |
Tharazi97
force-pushed
the
equeue_chain_problem
branch
from
05d6f25 to
53be630
Compare
0xc0170
approved these changes
Sep 17, 2019
maciejbocianski
approved these changes
Sep 17, 2019
|
CI started meanwhile |
Test run: SUCCESSSummary: 11 of 11 test jobs passed |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
If queues are chained, it is needed to unchain them first, before calling destroy, or call the destroy function on queues in order that chained queues are destroyed first. Destroying queues in wrong order would result in errors or other program malfunctions.
Fixes: #11482
Pull request type
Reviewers
@maciejbocianski @jamesbeyond @kimlep01 @geky @kjbracey-arm
Release Notes